feat: limit max guides generated per feature via an option #271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to
Create some absurd shapes as described in #267 or allow a high nbFeatures. Set
limitGuidesPerFeature
on your cad control (defaults to 3). Observe that the max number of snapping guides ever shown on the screen isnbFeatures X limitGuidesPerFeatures
Notes on Implementation
I included lodash here as a peer dependency as my project uses it anyway. The main need was to get access to
sortByIndex
which allows theincludedCoords
array to be built optimally in theparseCoordList
function. This can easily be replaced by something like the following with efficiency tradeoffsOthers
Fixes #267