feat: allow to modifiy circle geometry #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
danji90
approved these changes
May 8, 2024
src/control/cad.js
Outdated
| if (index > -1) { | ||
| features.splice(index, 1); | ||
| const currentFeatures = [editFeature, drawFeature].filter((f) => !!f); | ||
| const nb = nbFeatures || 1; |
There was a problem hiding this comment.
why is nbFeatures more readable then numFeatures? Maybe numberFeatures?
And can we put the default value in the arguments?
getClosestFeatures(coordinate, nbFeatures = 1)
There was a problem hiding this comment.
The node version in vercel needs to be upgraded and the Cypress tests are failing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to
Add a manually a feature with a circle geometry in the index.html file, the try to modify it.
Others
WIP:if it's necessary.IMPORTANT: Squash commits before or on merge to prevent every small commit being written into the change log. The Pull Request title will be written as message for the new commit containing the squashed commits and there fore needs to be in conventional-commit format