Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependency in 4.2.9 #564

Closed
huard opened this issue Jan 22, 2021 · 4 comments · Fixed by #565
Closed

Missing dependency in 4.2.9 #564

huard opened this issue Jan 22, 2021 · 4 comments · Fixed by #565

Comments

@huard
Copy link
Collaborator

huard commented Jan 22, 2021

Description

sphinx is not in requirements but is imported by pywps.test.

This does not seem to be a problem in master, but not sure if it because the issue was fixed, or the commit not pulled into master.

Steps to Reproduce

conda create -n pywps4.2.9 python=3.7
conda activate pywps4.2.9
python setup.py develop
python

Then

from pywps import tests
Python 3.7.9 | packaged by conda-forge | (default, Dec  9 2020, 21:08:20) 
[GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from pywps import tests
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/david/src/pywps/pywps/tests.py", line 15, in <module>
    from pywps.ext_autodoc import MetadataUrl
  File "/home/david/src/pywps/pywps/ext_autodoc.py", line 2, in <module>
    from sphinx.ext.autodoc import ClassDocumenter, bool_option
ModuleNotFoundError: No module named 'sphinx'





# Additional Information
@tlvu
Copy link
Collaborator

tlvu commented Jan 22, 2021

Sphinx is in

so that might explain why it's passing on Travis-CI https://travis-ci.org/github/geopython/pywps/builds/750280910

@tlvu
Copy link
Collaborator

tlvu commented Jan 22, 2021

That's coming from my commit 2a55b6e, so should I have created the MetadataUrl class in pywps.app.Common instead?

@tlvu
Copy link
Collaborator

tlvu commented Jan 22, 2021

I introduced the commit above in this PR #542. It was my first time touching pywps code. The class MetadataUrl should probably be in pywps.app.Common together with Metadata instead. Will submit a PR for this.

@cehbrecht
Copy link
Collaborator

fixed by PR #565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants