-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
static build failure on linux with gcc 13 #127
Comments
I see the same error with Clang 16.0.0 |
gcc 12 works, but I couldnt get clang working from clang 11+ |
I think @brendan-ward was the one implementing the static build (sorry if I'm wrong). Any idea what's going on? |
The static build just builds the pinned version of GEOS (git submodule for But in general, build issues with static are most likely build issues with GEOS as of that version. However, it looks like there are other GCC 13 issues coming directly from GEOS that may need to be resolved first: libgeos/geos#860 (comment) Those will need to be fixed upstream and we'll need to update the pinned version to that. For GEOS 3.11.x, it looks like the latest tested version of clang is whatever is installed on Ubuntu 20.04 (clang 1.10). However, on GEOS We should probably also add a bit more documentation for the static build to indicate the supported (or at least tested) build environment. Will try to put together a PR to bump us up to 3.11.2 and add a bit more docs shortly. |
Since GCC 13 is not yet released, it is not easy to test and probably should be out of scope here until it is released (and preferably available with installable packages for Ubuntu / Debian). GCC 12 seems to work fine, and clang 14 appears to work for at GEOS 3.11.2. |
Thanks. gcc-13 is in debian experimental https://packages.debian.org/experimental/gcc-13 , Fedora 38 & Rawhide https://packages.fedoraproject.org/pkgs/gcc/gcc/ Anyways, it would be great to get a new release of geos with #128 included. |
I made a new release. |
GEOS release 3.11.2 still fails to compile with gcc 13 / clang 16. But there is now version 3.11.3 which does compile with both compilers (tested on arch linux). #139 The last missing $ git diff 3.11.2 3.11.3 -- include/geos/shape/fractal/HilbertEncoder.h
diff --git a/include/geos/shape/fractal/HilbertEncoder.h b/include/geos/shape/fractal/HilbertEncoder.h
index 61c0010d4..0126d3d95 100644
--- a/include/geos/shape/fractal/HilbertEncoder.h
+++ b/include/geos/shape/fractal/HilbertEncoder.h
@@ -16,6 +16,7 @@
#pragma once
#include <geos/export.h>
+#include <cstdint>
#include <string>
#include <vector> |
I've opened #144 to fix this by updating the bundled version to 3.12.1 |
The text was updated successfully, but these errors were encountered: