Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text symbolizer resets color to #000000 #524

Closed
rdewit opened this issue Feb 21, 2022 · 1 comment · Fixed by #532
Closed

Text symbolizer resets color to #000000 #524

rdewit opened this issue Feb 21, 2022 · 1 comment · Fixed by #532
Assignees
Labels
bug Something isn't working

Comments

@rdewit
Copy link

rdewit commented Feb 21, 2022

Bug

Describe the bug
The SLD parser appears to not parse the text color properly and resets it to #000000. This happens with SLDs from QGIS as well as the SLD generated by the demo app.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://geostyler.github.io/geostyler-demo/
  2. Edit Rule 1 to be of Kind: Text and choose a color other than black
  3. Copy the SLD in the Code Editor to clipboard
  4. Reload the page and paste the SLD from clipboard
  5. Observe that the CSS parameter fill in Fill changes from your chosen color to #000000

Expected behavior
The SLD parser should recognize the the color and not change it to the default.

Additional context
I had a quick glance through the code of the SLD parser and I couldn't immediately see what is going wrong as it tries to extract the fill and fill-opacity from the CSS parameters.

@rdewit rdewit added the bug Something isn't working label Feb 21, 2022
@jansule
Copy link
Contributor

jansule commented Feb 22, 2022

Thanks for the info @rdewit.

@KaiVolland fixed this in #532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants