fix: Test if opacity is realy undefined #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ger-benjamin
force-pushed
the
967-test-opacity-is-really-undefined
branch
from
a615412
to
5d11f43
Compare
jansule
reviewed
Oct 7, 2024
There was a problem hiding this comment.
Very nice! Thanks @ger-benjamin. Just a small remark we might want to address first.
ger-benjamin
force-pushed
the
967-test-opacity-is-really-undefined
branch
2 times, most recently
from
e90d898
to
3e66f33
Compare
|
More changes than expected, but I think is all right. |
KaiVolland
approved these changes
Oct 8, 2024
ger-benjamin
force-pushed
the
967-test-opacity-is-really-undefined
branch
2 times, most recently
from
5bf44a9
to
4e7104b
Compare
BREAKING CHANGE: opacity is not longer forced to be 1 on text symbolizer.
ger-benjamin
force-pushed
the
967-test-opacity-is-really-undefined
branch
from
4e7104b
to
43fc38a
Compare
jansule
approved these changes
Oct 8, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 9, 2024
## [7.0.0](v6.1.2...v7.0.0) (2024-10-09) ### ⚠ BREAKING CHANGES * opacity will no longer be set to 1 on text symbolizer if opacity was not explicitly set. ### Bug Fixes * test if opacity is really undefined ([#968](#968)) ([858b42b](858b42b))
|
🎉 This PR is included in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #967
Test if opacity value is undefined or null, but not 0.