Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for geotiffs with ModelTransformation but without ModelPixelScale #40

Open
beihl opened this issue Feb 19, 2018 · 4 comments
Open

Comments

@beihl
Copy link

beihl commented Feb 19, 2018

GEOTiffs without ModelPixelScale but WITH ModelTransformation are possible ::
http://geotiff.maptools.org/spec/geotiff2.6.html#2.6

Currently getResolution() fails for these images.

@beihl
Copy link
Author

beihl commented Feb 20, 2018

Here is how GDAL's geotiff driver handles this :

If GeoPixelScale exists:
https://github.com/OSGeo/gdal/blob/trunk/gdal/frmts/gtiff/geotiff.cpp#L14372
ELSE if ModelTransformation exists :
https://github.com/OSGeo/gdal/blob/trunk/gdal/frmts/gtiff/geotiff.cpp#L14457

@constantinius
Copy link
Member

Thanks, good catch. Do you happen to have a test file with that condition you are willing to share so that I can make an automated test for this?

@beihl
Copy link
Author

beihl commented Feb 20, 2018

Sure.
no_pixelscale_or_tiepoints.tiff

@beihl beihl closed this as completed Feb 20, 2018
@beihl beihl reopened this Feb 20, 2018
@constantinius
Copy link
Member

Okay, this is done with 5ab27ad, 1c6b5ad and tests with fc05fee

Could you test this yourself?
Btw: I referenced your image in the test setup script, would it be possible to leave it there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants