Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On macOS a subsequent navigation fails #33

Closed
johankool opened this issue Jun 28, 2023 · 2 comments · Fixed by #43 or #44
Closed

On macOS a subsequent navigation fails #33

johankool opened this issue Jun 28, 2023 · 2 comments · Fixed by #43 or #44
Assignees
@johankool @pauldekkers
Labels
macOS Applies to macOS platform
Milestone
2.0

Comments

@johankool
Copy link
Collaborator

Steps to reproduce:

  1. Search for "eva"
  2. Tap first result
  3. Go back
  4. Tap second result

Actual behavior:

Nothing happens

Expected behavior:

Open second result
@johankool johankool added the macOS Applies to macOS platform label Jun 28, 2023
@johankool johankool added this to the 2.0 milestone Jun 28, 2023
@johankool johankool self-assigned this Jun 28, 2023
@johankool johankool linked a pull request Jul 7, 2023 that will close this issue
Hacky way to fix destination not getting nilled on macOS 13+ #43
Merged
@johankool johankool mentioned this issue Jul 7, 2023
Merged
@johankool
Copy link
Collaborator Author

Proper fix here: pointfreeco/swift-composable-architecture#2182

@johankool johankool reopened this Jul 31, 2023
@johankool johankool mentioned this issue Jul 31, 2023
Merged
@johankool johankool linked a pull request Jul 31, 2023 that will close this issue
TCA 1.0! Includes proper fix destination not getting nilled on macOS 13+ #44
Merged
@RianneBoortman
Copy link

RianneBoortman commented Aug 11, 2023 •
edited
Loading

Tested on:

  • MacBook Pro (2018), MacOS 13.4.1
    Version:
  • TestFlight geteduroam Test version 2.0(47)

✅ test approved
I now see the expected behaviour happening. When I go back, and tap on that first item again, that section is opened and I see the profile is downloaded again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johankool johankool

@pauldekkers pauldekkers

Labels
macOS Applies to macOS platform
Projects
None yet
Milestone
2.0
3 participants
@johankool @pauldekkers @RianneBoortman