Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome : Unable to click on list-encapsulated markdown editor fields #1037

Closed
parcand opened this issue Mar 23, 2017 · 15 comments
Closed

Chrome : Unable to click on list-encapsulated markdown editor fields #1037

parcand opened this issue Mar 23, 2017 · 15 comments
Assignees
Labels

Comments

@parcand
Copy link
Contributor

parcand commented Mar 23, 2017

List-encapsulated markdown editor fields are not responding to mouse clicks in Chrome.

capture d ecran 2017-03-23 a 10 54 51

@carlu93
Copy link

carlu93 commented Mar 24, 2017

I can confirm this happening on Windows 10 with Chrome 59 dev. Right clicking in the text will move the cursor to the desired place. Left clicking and dragging is not working.

@teroyks
Copy link

teroyks commented Apr 5, 2017

I have the same issue (latest Grav, macOS Sierra, Chrome 57.0.

Works fine on latest Safari.

@lukepolak
Copy link

Same here.

You can get into editor by clicking on any toolbar buttons or by tabbing from previous field in list, so that's workaround for me for now. Also, sometimes contents of those editor fields are not shown when you enter to edit that page.

Any idea what could cause this?

@flaviocopes
Copy link
Contributor

This is surely a regression, as I'm sure it worked before. Need to find out the commit that introduced the problem, on it.

@flaviocopes
Copy link
Contributor

@w00fz I tracked this down to the sortablejs library bump in composer.json in 49a9c43.

Setting it to "sortablejs": "1.4.2" (instead of ^1.5.1) and rebuilding the js, works fine again.

Could not find a changelog for that lib, will need to git-bisect (quite a few commits since 1.4.2) until I find what is the issue.
In the meantime @rhukster I pushed an updated vendor lib so if we want to release, it will fix the problem.

@w00fz
Copy link
Member

w00fz commented Apr 12, 2017

Might be a setting that needs enabling.

@honzabilek4
Copy link

Hi,
this is still relevant even after the latest admin plugin update to version 1.6.0.

  • Left click doesn't move the cursor, right click works.
  • Tested in various browsers (Firefox, Safari, Edge..) however, it affects only Chrome (both Win/macOS versions)

Can we please reopen this issue?

@rhukster rhukster reopened this Sep 19, 2017
@rhukster
Copy link
Member

Grrr.. thought this was sorted

@rhukster rhukster removed the fixed label Sep 19, 2017
@w00fz
Copy link
Member

w00fz commented Sep 26, 2017

What is the Chrome version you are using @honzabilek4 ? I did see this issue myself but after I upgraded Chrome it seems to be working fine again.
I'm running Version 61.0.3163.100 (Official Build) (64-bit).

Can you check your version? And if it's still an issue could you please paste a yaml sample for me to use? As of right now I can't reproduce this issue anymore.

@honzabilek4
Copy link

honzabilek4 commented Sep 26, 2017

Hi,
I've got the exact same version of Chrome right now.
The very minimal yaml snippet having this issue would be:

title: Home
'@extends':
    type: default
    context: blueprints://pages
form:
  fields:
    tabs:
      fields:        
        customTab:
          type: tab
          title: Custom Tab
          @ordering: -3
          fields:
            header.persons:
              type: list
              title: Markdown list
              collapsed: false
              style: vertical
              btnLabel: Add Item
              fields:
                .description:
                  type: markdown
                  label: Text

In aa18112 @flaviocopes fixed the issue by reverting sortalbejs to version ^1.4.2, however in current version of admin plugin sortablejs is on ^1.6.0. Could this possibly fix it again?

@w00fz
Copy link
Member

w00fz commented Sep 27, 2017

Well it certainly could but I’d rather try to resolve the issue while keeping the dependencies we use up to date.

I will take a look today, thanks for the snippet!

@w00fz
Copy link
Member

w00fz commented Sep 27, 2017

Hey @honzabilek4,
I just tested with your yaml and still cannot reproduce. However I just realized I did update the dependencies very recently (814298c) and after 1.6.0. The update included codemirror so I'm thinking this issue is not reproducible for me because I'm running on persistent develop environment.

Would you mind trying out the develop version of admin to see if that is actually sorting out the issue for you?

Cheers

@honzabilek4
Copy link

honzabilek4 commented Sep 27, 2017

Sure, I'll let you know asap.

@honzabilek4
Copy link

Okay, I can now confirm that after upgrading the dependencies in 814298c everything works just as fine.
Cool. Thanks for your help @w00fz.

@rhukster
Copy link
Member

Great thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants