Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modular Content moving to root when saving since v1.3.2 #1059

Closed
carlu93 opened this issue Apr 11, 2017 · 10 comments
Closed

Modular Content moving to root when saving since v1.3.2 #1059

carlu93 opened this issue Apr 11, 2017 · 10 comments
Assignees

Comments

@carlu93
Copy link

carlu93 commented Apr 11, 2017

Since the newest update, there's a serious problem with the admin plugin.
as soon as i save some modular page/content the module gets moved outside the parent to the ROOT of the grav pages folder. Unfortunately i have no screenshot, because i already moved back to v1.3.1, but this happened to every module i saved.

@flaviocopes
Copy link
Contributor

I'm not able to replicate. Which browser are you using? Can you also try clearing the browser cache?

@axel-rank
Copy link

I cannot replicate too. Using latest Grav + Admin + Cleared Browser Cache (Firefox 52.0.2).

@paulhibbitts
Copy link
Contributor

I also updated to latest version and running with MAMP + Chrome I was able to save modular pages a-ok.

@OleVik
Copy link
Contributor

OleVik commented Apr 11, 2017

Could this be because the type of template changed inadvertently? One thing I noticed with Grav + Admin, from source, last night was that the field-select for template would jump back to Default from Modular on occasion, but I haven't tested whether it occurs beyond my out-of-date Chrome.

@carlu93
Copy link
Author

carlu93 commented Apr 11, 2017

The Problem @OleVik mentioned happened to me too! I'm using Chrome V58

@rhukster
Copy link
Member

Hmm.. i did 'fix' an issue yesterday to return default from the task: getChildType (which is called every time you change parent) if the value was not set.

Could this be the issue?

@rhukster rhukster added the bug label Apr 11, 2017
@rhukster
Copy link
Member

Ok, I think this might need a little JS work to fix. It's resetting to default now every time you change parent (or move). I guess it was expecting an error before.

@rhukster
Copy link
Member

Ok, looked into it a little more. Seems this getChildType always returns default even if it's not set. My fix was to address an issue when the method was called with a bad rawroute (ie when typing in the parents select field).

But seems this is a fundamental new thing that changes behavior since Grav 1.1.17. We'll look into how best to sort it.

@carlu93
Copy link
Author

carlu93 commented Apr 11, 2017

Great! Thanks. I'll test the fix as soon as it's out.

@flaviocopes
Copy link
Contributor

Ok I can replicate the change of the page template. Looking into it.
But I still cannot replicate the original issue reported, which is - moving the page folder to root after saving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants