Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running 1.9 branch local doesn't work, Output filename not configured on Webpack #1655

Closed
hdwebpros opened this issue Apr 17, 2019 · 5 comments

Comments

@hdwebpros
Copy link
Contributor

I'm trying to run 1.9 branch locally to test and submit fixes, but errors persist.

Steps to reproduce:

  • Go to https://github.com/getgrav/grav-plugin-admin and create a fork by clicking the fork button. I hope you didn't create one already. If you did, you'll likely have to just delete your old fork and make a new one. Babker can help if that's the case.
  • Clone that fork off to the side for now
  • Download the 1.6 Beta grav (no admin, just Grav)
  • Extract that Grav in your local setup (Homestead area, etc) and setup your hosts file to look for it
  • use vagrant ssh or whatever ssh tool ya want and go to the site root for that grav install and run php bin/gpm install login. Say yes to installing the other dependncies
  • Once installed, go to your user/plugins/ folder and create one called admin
  • Copy your forked repo over to that admin folder you just created
  • On your command prompt, navigate to that admin folder root then type git checkout 1.9
  • Finally, go to your site and make the admin account and log in. Go to a page edit screen. You won't see the unset icon anywhere if you had luck like me
  • navigate to themes/grav within your admin plugin and run npm install
  • Now, running npm run dev should work. It doesn't. That's where I'm hung up.

I get the following error:

Output filename not configured.

There is no output filename configured in the Webpack conf file. I'm stuck here, can't compile the JS to test any potential fixes, like trying to help out in the issue: #1427

@w00fz
Copy link
Member

w00fz commented Apr 17, 2019

Admin still uses the old setup where I preferred Gulp. I never got to update it to use webpack like everything else we use nowadays.

For compiling admin you have to gulp js or gulp watch

@w00fz
Copy link
Member

w00fz commented Apr 17, 2019

I will also update the package.json to use the proper commands

@rhukster
Copy link
Member

Also make sure you use develop branch now for Grav and Admin as Grav 1.6 and Admin 1.9 are released.

@hdwebpros
Copy link
Contributor Author

Thanks for the update. I'll keep my eye out for the package.json update

@w00fz
Copy link
Member

w00fz commented Apr 17, 2019

I updated it with 9ae5502 👍

@w00fz w00fz closed this as completed Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants