Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selection highlight in editor #977

Closed
leotiger opened this issue Feb 14, 2017 · 6 comments
Closed

selection highlight in editor #977

leotiger opened this issue Feb 14, 2017 · 6 comments
Assignees
Labels

Comments

@leotiger
Copy link

This has been reported before but from my experience: selection highlighting still does not work correctly in the codemirror instances out of the box. This is one of the biggest issues with the current editor implementation. I suggested StackEdit, but with highlighting resolved the current editor is a valid alternative.

@leotiger
Copy link
Author

screen shot 2017-02-14 at 17 41 51

(Selection not visible but text selected as cursor is not visible)

screen shot 2017-02-14 at 17 42 05

(Nothing selected, cursor visible)

@leotiger
Copy link
Author

I found the problem, thanks to @flaviocopes and his insistence. The problem relies in the contrast and highlight color used. Depending on color profile it's not working. I would suggest to use something closer to preview. Color profile for highlighting in preview seems to be fail-safe.

u

@flaviocopes
Copy link
Contributor

Ok the problem is, when something is selected, the cursor is not visible, right?

@leotiger
Copy link
Author

No, the problem is that the selection does not appear highlighted. It's like working blind as you don't see selected characters, words, paragraphs distinguished from the rest of the content.

Or to put it the other way around: It's normal that you don't see the input cursor when you select content chunks.

A simple fix is to choose a color that conveys more to the standards for highlighting. I believe that codemirror uses a fixed color scheme right now and this color scheme does not work for example with the standard color scheme that comes with my monitors.

@leotiger
Copy link
Author

@flaviocopes Thanks for looking into this. One more hint: As highlighting works for you, the screenshots work for you as well, you will see, even on my screenshots, the text chunks highlighted whereas on my monitors the screenshots do not show nearly a difference at all.

@w00fz w00fz self-assigned this Mar 8, 2017
@w00fz w00fz closed this as completed in ba229a3 Mar 8, 2017
@w00fz
Copy link
Member

w00fz commented Mar 8, 2017

This is now changed to use your OS native highlight colors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants