Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint checks not passing on master #161

Closed
gdurif opened this issue Apr 8, 2021 · 2 comments
Closed

Lint checks not passing on master #161

gdurif opened this issue Apr 8, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@gdurif
Copy link
Contributor

gdurif commented Apr 8, 2021

See https://github.com/getkeops/keops/pull/160/checks

ref_jmlr was branched from master, and the files concerned by the failing checks are not modified by PR #160 so there seems to be an issue on master regarding these files.

@gdurif gdurif added the bug Something isn't working label Apr 8, 2021
@gdurif
Copy link
Contributor Author

gdurif commented Apr 8, 2021

Here is the failed check result:

Run psf/black@stable
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.9.4/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.9.4/x64/lib
/usr/bin/docker run --name e4d503d636832a4ccdbe4b2ad24f097b50_814616 --label 5588e4 --workdir /github/workspace --rm -e pythonLocation -e LD_LIBRARY_PATH -e HOME -e GITHUB_JOB -e GITHUB_REF -e GITHUB_SHA -e GITHUB_REPOSITORY -e GITHUB_REPOSITORY_OWNER -e GITHUB_RUN_ID -e GITHUB_RUN_NUMBER -e GITHUB_RETENTION_DAYS -e GITHUB_ACTOR -e GITHUB_WORKFLOW -e GITHUB_HEAD_REF -e GITHUB_BASE_REF -e GITHUB_EVENT_NAME -e GITHUB_SERVER_URL -e GITHUB_API_URL -e GITHUB_GRAPHQL_URL -e GITHUB_WORKSPACE -e GITHUB_ACTION -e GITHUB_EVENT_PATH -e GITHUB_ACTION_REPOSITORY -e GITHUB_ACTION_REF -e GITHUB_PATH -e GITHUB_ENV -e RUNNER_OS -e RUNNER_TOOL_CACHE -e RUNNER_TEMP -e RUNNER_WORKSPACE -e ACTIONS_RUNTIME_URL -e ACTIONS_RUNTIME_TOKEN -e ACTIONS_CACHE_URL -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" -v "/home/runner/work/keops/keops":"/github/workspace" 5588e4:d503d636832a4ccdbe4b2ad24f097b50
--- pykeops/common/lazy_tensor.py	2021-04-08 08:04:13.342171 +0000
+++ pykeops/common/lazy_tensor.py	2021-04-08 08:04:17.354406 +0000
@@ -2433,13 +2433,17 @@
         if other._shape[-1] == 1:
             return other.binary(self, "ComplexRealScal", **kwargs, is_complex=True)
         elif not is_complex_lazytensor(other):
             return self.mulop(other.real2complex())
         elif self._shape[-1] == 2:
-            return self.binary(other, "ComplexScal", **kwargs, is_complex=True, dimcheck=None)
+            return self.binary(
+                other, "ComplexScal", **kwargs, is_complex=True, dimcheck=None
+            )
         elif other._shape[-1] == 2:
-            return other.binary(self, "ComplexScal", **kwargs, is_complex=True, dimcheck=None)
+            return other.binary(
+                self, "ComplexScal", **kwargs, is_complex=True, dimcheck=None
+            )
         else:
             return self.binary(other, "ComplexMult", **kwargs, is_complex=True)
 
     def addop(self, other, **kwargs):
         if not is_complex_lazytensor(other):
would reformat pykeops/common/lazy_tensor.py
Oh no! 💥 💔 💥
1 file would be reformatted, 114 files would be left unchanged.

@jeanfeydy
Copy link
Contributor

Fixed with 584da40.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants