Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of un-exported interface InternalizeRefs #994

Closed
valentinegu opened this issue Jul 24, 2024 · 1 comment · Fixed by #998
Closed

Use of un-exported interface InternalizeRefs #994

valentinegu opened this issue Jul 24, 2024 · 1 comment · Fixed by #998

Comments

@valentinegu
Copy link

Hello Team,

I have a use-case requiring me to overload the current RefString\RefPath functions,
In my use case the ref may contain non-ascii chars and my overload hashes Ref field.
up to v0.125.0 my use-case was possible since InternalizeRefs signature was:

func (doc *T) InternalizeRefs(ctx context.Context, refNameResolver func(ref string) string) {

which allowed overloading refNameResolver function,

Current implementation:

func (doc *T) InternalizeRefs(ctx context.Context, refNameResolver func(*T, componentRef) string) {

uses the componentRef which isn't exported, as a result my use-case isn't really possible (apart of doing major reimplementation),
Is there am option to export this interface thus allowing me to achieve previously possible behavior?

@fenollp
Copy link
Collaborator

fenollp commented Jul 27, 2024

Feel free to move #983 further :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants