-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error page always rendered in default language for some languages #4834
Comments
This issue is only reproducible for some languages, we've tested following languages:
|
Ha, it almost looks like only |
That's super weird... |
@distantnative I'm not involved, I just noticed it looks like it's broken alphabetically. |
@distantnative EN is always the secondary language in manual tests. Only DE passed the test when we changed the primary language. |
I think I am getting to the source of the problem, without quite knowing yet how to solve it:
On the one hand, I see how we thought a fallback to also check for a page This is why right now the secondary-language error page cannot really be reached. I didn't check for German, but I would be surprised if that one is actually working either. |
I looked into this again. I am not sure we can solve this:
I see two options, both not sure how to implement yet: |
Scenario to reproduce:
Have 2 languages:
"url" => "/"
"url" => "en"
If you visit
/en/asdf
, the url is right, but the content is not translated (appears in default language).If you visite
/asdf
, the url is right and the content is translated.Fix:
If I set the french
url => "fr"
, it works as intended. Both "/" and "/en" are displaying the right locale.If I set the english as default, with
url => "/"
, it works as intended.This means I cannot have French as default language with
url => "/"
.Same issue as this user: https://forum.getkirby.com/t/error-page-is-shown-in-wrong-language/18084/9
Originally posted by @juliencharette in #2609 (comment)
The text was updated successfully, but these errors were encountered: