Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Wrong ENV variable documented for Google Single Sign-On #374

Closed
Antho331364 opened this issue Jul 7, 2024 · 0 comments · Fixed by getlago/lago-doc#164
Closed

Comments

@Antho331364
Copy link

Describe the bug
On the official documentation it is documented to declare the following environment variables to use the Google SSO functionality:

  • LAGO_GOOGLE_AUTH_CLIENT_ID
  • LAGO_GOOGLE_AUTH_CLIENT_SECRET

These variables are not the right ones to declare according to the code itself.

The following environment variables must be declared:

  • GOOGLE_AUTH_CLIENT_ID
  • GOOGLE_AUTH_CLIENT_SECRET

In addition to this, you also need to edit the docker-compose.yml and add the env variables to the api service block of the compose file:

 environment:
    ...
    - GOOGLE_AUTH_CLIENT_ID=${GOOGLE_AUTH_CLIENT_ID:-}
    - GOOGLE_AUTH_CLIENT_SECRET=${GOOGLE_AUTH_CLIENT_SECRET:-}

Last but not least, it's not documented currently anywhere but you need to set the Allowed redirect URIs in your Google Cloud console where you define your OAuth credentials for Lago which is the Lago front URL(with port if different than 80 or 443) followed by "/auth/google/callback". Ex: http(s)://yourdomain.com/auth/google/callback

And the Allowed JavaScript origins set to the Lago front URL(with port if different than 80 or 443). Ex : http(s)://yourdomain.com

Expected behavior
Well documented environment variables for Google SSO feature and additional instructions to update the docker-compose.yml file according to these variables, plus the allowed javascript origin and allowed redirect URIs to set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant