Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] route53 tagging for hostedzones & list_tags_for_resources does not work properly #8130

Open
zkarpinski opened this issue Sep 19, 2024 · 0 comments · May be fixed by #8131
Open

[BUG] route53 tagging for hostedzones & list_tags_for_resources does not work properly #8130

zkarpinski opened this issue Sep 19, 2024 · 0 comments · May be fixed by #8131

Comments

@zkarpinski
Copy link
Contributor

zkarpinski commented Sep 19, 2024

There are two bugs for route53.

To recreate, add assert len(response["ResourceTagSets"]) == 2 in test_route53.py -> test_list_tags_for_resources() above for set in response["ResourceTagSets"]: on line 588.

list_tags_for_resources() doesn't actually return anything and it's stems from 3 bugs.

  1. The list_or_change_tags_for_resource_request api doesn't decode the url encoding in the ID. Thus, characters like "/" are encoded when tags are added. This impacts hostedzones which have slashes in the ID. list_tags_for_resources the id are not encoded, so the key is never found and returns no results.
  2. The list of ids isn't capture correctly, it's passing a dictionary instead of the list of ids.
  3. The template for list_tags_for_resources doesn't work as expected and needs refactoring.

The test-case mentioned doesn't test what you expect and thus passes incorrectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant