Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin click-module, because it causes black to crash #4984

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

bblommers
Copy link
Collaborator

@bblommers bblommers commented Mar 29, 2022

psf/black#2964
pallets/click#2232

Edit: At the core this is an issue with black, and we may have to upgrade black to get around this, but downgrading click is the path of least resistance for now.

@bblommers bblommers added this to the 3.1.4 milestone Mar 29, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2022

Codecov Report

Merging #4984 (55a45a4) into master (5e0941e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4984   +/-   ##
=======================================
  Coverage   95.64%   95.64%           
=======================================
  Files         622      622           
  Lines       65430    65430           
=======================================
  Hits        62583    62583           
  Misses       2847     2847           
Flag Coverage Δ
servertests 36.11% <100.00%> (ø)
unittests 95.58% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
moto/__init__.py 97.10% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e10699...55a45a4. Read the comment docs.

@bblommers bblommers merged commit a271057 into master Mar 29, 2022
@bblommers bblommers deleted the bblommers-patch-click branch March 29, 2022 13:10
@github-actions
Copy link
Contributor

This is now part of moto >= 3.1.4.dev2

sahilshah6196 pushed a commit to EBSCOIS/moto that referenced this pull request Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants