Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tooltip in submissions table in geopoints #635

Closed
dbemke opened this issue Apr 15, 2024 · 3 comments · Fixed by getodk/central-frontend#975
Closed

Missing tooltip in submissions table in geopoints #635

dbemke opened this issue Apr 15, 2024 · 3 comments · Fixed by getodk/central-frontend#975
Assignees
Labels
behavior verified Behavior has been manually verified bug frontend Requires a change to the UI styles Changes to CSS

Comments

@dbemke
Copy link

dbemke commented Apr 15, 2024

Problem description

In submissions table when you hover over geopoints submission data (e.g. All widgets form) the tooltip isn’t displayed. It’s impossible to read the whole data in geopoints.

Steps to reproduce the problem

  1. Send a submission of All widgets form with all Geo question types filled.
  2. Go to Central to submissions page.
  3. Hover over geopoint data in the submission table.

Screenshot

https://jam.dev/c/9f3f9ea7-84e1-4268-939d-2c00ddff37e9

Expected behavior

When you hover over data that is longer than the column width, the tooltip should appear

Central version shown in version.txt

https://staging.getodk.cloud/
versions:
f0b2a90 (v2023.5.1-5-gf0b2a90)
+e216a1176b196b2b168ce2d0164eb657061653e0 client (v2023.5.0-45-ge216a117)
+59e2165c01534d651385342d14d8789955320bcd server (v2023.5.0-51-g59e2165c)
https://test.getodk.cloud/
versions:
f0b2a90 (v2023.5.1-5-gf0b2a90)
+177ab0713f98f2f0f8e46b194b0840e660014c89 client (v2023.5.0-71-g177ab071)
+59e2165c01534d651385342d14d8789955320bcd server (v2023.5.0-51-g59e2165c)

Browser

Chrome and Firefox

@matthew-white matthew-white added bug frontend Requires a change to the UI needs testing Needs manual testing styles Changes to CSS labels Apr 15, 2024
@github-project-automation github-project-automation bot moved this to 🕒 backlog in ODK Central Apr 15, 2024
@matthew-white
Copy link
Member

The lack of a tooltip is actually by design. The thought is that geopoint values shouldn't ever end up being truncated, so we should enhance performance by skipping the tooltip. Most columns max out at 250px, but geopoint columns are allowed to grow up to 500px. Or at least they're supposed to be. In practice, I can see that that's not happening: they're 250px instead of 500px. I think this is an issue introduced by getodk/central-frontend#811 in v2023.3. The CSS for the default 250px has become more specific, so the CSS for the geopoint 500px is never applied. We should be able to fix this pretty easily.

@ktuite ktuite moved this from 🕒 backlog to ✏️ in progress in ODK Central Apr 22, 2024
@github-project-automation github-project-automation bot moved this from ✏️ in progress to ✅ done in ODK Central Apr 23, 2024
@dbemke
Copy link
Author

dbemke commented Apr 23, 2024

Tested with success!

@srujner
Copy link

srujner commented Apr 23, 2024

Tested with success!

@srujner srujner added behavior verified Behavior has been manually verified and removed needs testing Needs manual testing labels Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behavior verified Behavior has been manually verified bug frontend Requires a change to the UI styles Changes to CSS
Projects
Status: ✅ done
Development

Successfully merging a pull request may close this issue.

4 participants