Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we distribute dependencies with the bundle? #1947

Closed
carolynvs opened this issue Feb 27, 2022 · 1 comment
Closed

Should we distribute dependencies with the bundle? #1947

carolynvs opened this issue Feb 27, 2022 · 1 comment
Labels
enhancement New code incoming! hmm 🛑🤔 Needs more thinking time. Don't start on it yet, please.
Milestone

Comments

@carolynvs
Copy link
Member

Let's say that we have a bundle that depends upon another bundle, and its dependency section contains an exact full reference, e.g. getporter/mysql:v1.2.3. When the root bundle is relocated across an airgap, the referenced dependency is no longer accessible. Even if the dependency is relocated manually, how would the root bundle resolve the dependency to the new location?

When porter archives a bundle, it should archive the dependencies into the same archive file. When the archive is published, porter should publish each dependency, and then publish the root bundle with a relocation-mapping.json file that includes the mapping for each dependency.

bundlename-version.tgz
- layers
- manifest.json
- dependencies/
  - bundlename-version/ ...
    - layers
    - manifest.json

It should be an option to only archive the root bundle or archive all dependencies (not sure which should be the default). This will allow an administrator to do a simplified transfer of a bundle and all its dependencies, or when transferring lots of bundles, do each one separately to avoid redundantly large bundles.

We could potentially support archiving all dependencies into separate archives, and if we encounter an archive with the same desired name, do not overwrite it. That way the admin could call archive on each bundle they care about and would ultimately get a directory filled with all unique bundles to move to the airgapped environment.

wordpress-v1.2.3.tgz
mysql-v5.7.14.tgz
nginx-v0.23.2.tgz
@carolynvs carolynvs added enhancement New code incoming! hmm 🛑🤔 Needs more thinking time. Don't start on it yet, please. labels Feb 27, 2022
@carolynvs carolynvs added this to the Dependencies milestone Feb 27, 2022
@carolynvs
Copy link
Member Author

Duplicate of #554

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New code incoming! hmm 🛑🤔 Needs more thinking time. Don't start on it yet, please.
Projects
None yet
Development

No branches or pull requests

1 participant