Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build pulls referenced images when all we need is a digest #2576

Closed
carolynvs opened this issue Feb 14, 2023 · 0 comments · Fixed by #2579
Closed

Build pulls referenced images when all we need is a digest #2576

carolynvs opened this issue Feb 14, 2023 · 0 comments · Fixed by #2579
Assignees
@carolynvs
Labels
1 - 🍫 Eat chocolate _after_ emergency donuts performance 🏎💨 Tasks that improve the performance of Porter

Comments

@carolynvs
Copy link
Member

carolynvs commented Feb 14, 2023 •
edited
Loading

When porter build runs, during the step where we generate the bundle.json file we need to fetch the repository digest for all referenced images. Right now we do a full pull on each image, which for lots of images or large images is terribly slow. We should only retrieve the data we need, the repository digest.

See #2565
@carolynvs carolynvs added 1 - 🍫 Eat chocolate _after_ emergency donuts performance 🏎💨 Tasks that improve the performance of Porter labels Feb 14, 2023
@carolynvs carolynvs self-assigned this Feb 14, 2023
@carolynvs carolynvs mentioned this issue Feb 14, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carolynvs carolynvs

Labels
1 - 🍫 Eat chocolate _after_ emergency donuts performance 🏎💨 Tasks that improve the performance of Porter
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not pull referenced images during build carolynvs/porter
1 participant
@carolynvs