Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove panic = abort in Cargo.toml #2200

Open
szokeasaurusrex opened this issue Oct 24, 2024 · 0 comments
Open

Remove panic = abort in Cargo.toml #2200

szokeasaurusrex opened this issue Oct 24, 2024 · 0 comments

Comments

@szokeasaurusrex
Copy link
Member

szokeasaurusrex commented Oct 24, 2024

Setting panic to abort disables any panic handlers in Rust. While having this does likely reduce binary size, the downside is that panics immediately crash Sentry CLI, and they cannot be handled.

If we add Sentry to the CLI (#1821), Sentry would not be able to capture panics due to this option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant