Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop profiles when SentrySDK.startWithOptions is not called #3637

Open
armcknight opened this issue Feb 14, 2024 · 0 comments
Open

Stop profiles when SentrySDK.startWithOptions is not called #3637

armcknight opened this issue Feb 14, 2024 · 0 comments

Comments

@armcknight
Copy link
Member

          `h`: What if a user never calls `startWithOptions`? Then the tracer and launch profile would run forever if I'm not mistaken. The auto-generated transactions have a timeout of 30 seconds

if ([self isAutoGeneratedTransaction]) {
[self startDeadlineTimer];
}

but only if they have an idle timeout or waitForChildren

- (BOOL)isAutoGeneratedTransaction
{
return _configuration.waitForChildren || [self hasIdleTimeout];
}

The SentryTracerConfiguration.defaultConfiguration doesn't have an idle timeout or waitForChildren. One way to fix this would be to enable waitForChildren, or to add an extra flag that isAutoGeneratedTransaction check.

This is an edge case; I would be OK with fixing it with an upcoming PR.

Originally posted by @philipphofmann in #3621 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs Discussion
Development

No branches or pull requests

2 participants