Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing or deprecated fields on the event protocol #1028

Closed
Tracked by #56
marandaneto opened this issue Sep 29, 2022 · 1 comment · Fixed by #1038
Closed
Tracked by #56

Missing or deprecated fields on the event protocol #1028

marandaneto opened this issue Sep 29, 2022 · 1 comment · Fixed by #1038

Comments

@marandaneto
Copy link
Contributor

marandaneto commented Sep 29, 2022

Description

Relates to getsentry/team-mobile#56

DebugImage missing cpu_subtype and cpu_type.
Mechanism field meta isn't correctly typed, but it should be fine since it's iOS specific.
SentryApp missing app_memory, we likely set this one on SentryDevice, likely a confusion here between App's sandbox memory and Device memory.
SentryDevice Relay is missing screen_height_pixels and screen_width_pixels
SentryEvent deprecate culprit, missing errors but ideally not needed for SDKs, maybe useful for E2E tests.
SentryGpu missing graphics_shader_level, max_texture_size, supports_compute_shaders, supports_draw_call_instancing,
supports_geometry_shaders, supports_ray_tracing.
SentryRequest missing fragment, inferred_content_type, and SDK should deprecate/drop other.
SentryRuntime missing build, Relay is missing compiler.
SentryStackFrame missing stack_start, symbol, vars should be <string, any>, Relay is missing addr_mode, and frames_omitted.
SentryStackTrace missing lang, and snapshot.
SentryTraceContext missing client_sample_rate, exclusive_time, do we actually need them on the SDK?
SentryTransactionInfo, missing changes, original, propagations, do we actually need them on the SDK?
SentryUser, missing data <string, any>, geo, name.

@ueman
Copy link
Collaborator

ueman commented Sep 29, 2022

Related: #842

@ueman ueman mentioned this issue Oct 2, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants