From f19836d5062ff45eb0b36ec2fc7bbfab584f3f2c Mon Sep 17 00:00:00 2001 From: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com> Date: Wed, 29 Jun 2022 11:25:03 +0200 Subject: [PATCH 1/2] Add note for Hermes bundle manually --- src/platforms/react-native/manual-setup/hermes.mdx | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/platforms/react-native/manual-setup/hermes.mdx b/src/platforms/react-native/manual-setup/hermes.mdx index e8b38fbfc2654..7b4de85290795 100644 --- a/src/platforms/react-native/manual-setup/hermes.mdx +++ b/src/platforms/react-native/manual-setup/hermes.mdx @@ -32,6 +32,14 @@ If you are manually bundling and building React Native apps, follow this three-s ### Compile Sourcemaps + + +We're currently facing issues when bundling the `hermes` bundle and `source maps` manually. +We'd recommend not bundling it manually for now till this issue gets fixed. +Follow the [issue[(https://github.com/facebook/react-native/issues/34043) for more details. + + + 1. Bundle/minify with `metro` (`react-native`) to get the bundle (`.bundle`) and packager source map (`.packager.map`): ```bash {tabTitle:Android} From 0c56bfae350062dd0cdba9ac9dc7050deb263265 Mon Sep 17 00:00:00 2001 From: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com> Date: Wed, 29 Jun 2022 16:48:00 +0200 Subject: [PATCH 2/2] Update src/platforms/react-native/manual-setup/hermes.mdx Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com> --- src/platforms/react-native/manual-setup/hermes.mdx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/platforms/react-native/manual-setup/hermes.mdx b/src/platforms/react-native/manual-setup/hermes.mdx index 7b4de85290795..c24f85df71665 100644 --- a/src/platforms/react-native/manual-setup/hermes.mdx +++ b/src/platforms/react-native/manual-setup/hermes.mdx @@ -34,9 +34,9 @@ If you are manually bundling and building React Native apps, follow this three-s -We're currently facing issues when bundling the `hermes` bundle and `source maps` manually. -We'd recommend not bundling it manually for now till this issue gets fixed. -Follow the [issue[(https://github.com/facebook/react-native/issues/34043) for more details. +Currently, there is an issue when bundling the `hermes` bundle and `source maps` manually. +We recommend not bundling these manually until this is fixed. +Follow the [issue](https://github.com/facebook/react-native/issues/34043) for more details.