-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary dependency update while updating sentry SDK version #437
Comments
This is true for all the "web-framework" (or logger) dependencies. They should be removed from the main sentry-go library in my opinion. sentry-go is a library package and should have minimum dependencies. I use none of the sentry-go imported web frameworks so I don't want to have a dependency on them, but I'm forced to. 😞 Some related issues which underline that it might was a bad decision by sentry to import all kinds of things into the main sentry-go package:
It would be way better to provide separate packages containing the integrations for web-frameworks or loggers. This gives (paying) users of Sentry the freedom to choose what they are depending on in their codebase! |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Unfortunately this is still a problem but this issue didn't get attention so far... |
Let's track this in #156 |
Summary
Current sentry-go has a dependency with gin, so when we are going to update the sentry-go version, it requires an update of the proper gin version too.
However, by searching this repository, gin is only used for creating test & example codes.
Motivation
When I update sentry SDK version from v0.11.0 to v0.13.0, I found out it requires an update for gin too.
However, updating gin version seems unnecessary to us since this is actually not used in sentry.
It seems to be a burden for users to consider unnecessary dependency updates.
Could you please consider this case? 🙏
Additional Context
The text was updated successfully, but these errors were encountered: