Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit transaction.data inside contexts.trace.data #3626

Open
Tracked by #95
kahest opened this issue Aug 7, 2024 · 5 comments
Open
Tracked by #95

Emit transaction.data inside contexts.trace.data #3626

kahest opened this issue Aug 7, 2024 · 5 comments

Comments

@kahest
Copy link
Member

kahest commented Aug 7, 2024

  • find out if we already do this
  • if we don't implement it like this :)
@kahest kahest changed the title Android SDK Emit transaction.data inside contexts.trace.data Aug 7, 2024
@kahest kahest transferred this issue from getsentry/team-sdks Aug 7, 2024
@lbloder lbloder self-assigned this Aug 12, 2024
@lbloder
Copy link
Collaborator

lbloder commented Aug 16, 2024

@kahest We are currently sending transaction (root span) data as extra here. Should we keep that for the sake of backwards compatibility?

@kahest
Copy link
Member Author

kahest commented Aug 16, 2024

@lbloder I'm not sure, I don't have context why we do this - maybe @stefanosiano @markushi have an idea.

@stefanosiano
Copy link
Member

@kahest We are currently sending transaction (root span) data as extra here. Should we keep that for the sake of backwards compatibility?

I'd keep it for compatibility, also because we are updating v7.
We can think about removing it in v8, if it's not used by our product

@markushi
Copy link
Member

markushi commented Sep 2, 2024

@lbloder as discussed here, let's remove sending it as event.extra.

@adinauer
Copy link
Member

We'll only change v8 of the SDK due to potential PII stripping issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

5 participants