Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach request body for more MIME types #3656

Closed
adinauer opened this issue Aug 26, 2024 · 1 comment
Closed

Attach request body for more MIME types #3656

adinauer opened this issue Aug 26, 2024 · 1 comment
Assignees
Milestone

Comments

@adinauer
Copy link
Member

Problem Statement

Currently Sentry filters by MIME type when attaching the request body to an event, only doing so for JSON.

A user asked for this in #3641 (comment)

form-urlencoded requests are also used a lot, so I would like to support for “application/x-www-form-urlencoded”.

Solution Brainstorm

Python attaches JSON, form and files, see https://github.com/getsentry/sentry-python/blob/master/sentry_sdk%2Fintegrations%2F_wsgi_common.py#L129-L143.

We can extend from only JSON to more in v8.

@adinauer
Copy link
Member Author

@lee-jinhwan we've just released 8.0.0-beta.1 of the Java SDK which should now also attach the request body for forms. If you decide to give it a try, feedback would be great :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

1 participant