Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter all HttpExceptions in @sentry/nestjs #13064

Closed
Tracked by #12504
nicohrubec opened this issue Jul 26, 2024 · 0 comments · Fixed by #13120
Closed
Tracked by #12504

Filter all HttpExceptions in @sentry/nestjs #13064

nicohrubec opened this issue Jul 26, 2024 · 0 comments · Fixed by #13120
Assignees
@nicohrubec
Labels
Package: nestjs Issues related to the Sentry Nestjs SDK

Comments

@nicohrubec
Copy link
Contributor

nicohrubec commented Jul 26, 2024 •
edited
Loading

So far we are filtering exceptions on the status code and do not report 4xx errors. However, we actually only want to capture unexpected exceptions but all HttpExceptions are only ever thrown explicitly. Hence, we do not want to capture them and they should be filtered.
@nicohrubec nicohrubec mentioned this issue Jul 26, 2024
Open
@nicohrubec nicohrubec self-assigned this Jul 26, 2024
@nicohrubec nicohrubec added the Package: nestjs Issues related to the Sentry Nestjs SDK label Jul 26, 2024
@nicohrubec nicohrubec linked a pull request Jul 30, 2024 that will close this issue
feat(nestjs): Filter all HttpExceptions #13120
Merged
@pesix pesix mentioned this issue Aug 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicohrubec nicohrubec

Labels
Package: nestjs Issues related to the Sentry Nestjs SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(nestjs): Filter all HttpExceptions getsentry/sentry-javascript
2 participants
@nicohrubec and others