From 7b35a245c2088d0a6cac69863a8d27cb77d9d1fb Mon Sep 17 00:00:00 2001 From: Rodolfo Carvalho Date: Thu, 20 Feb 2020 01:33:03 +0100 Subject: [PATCH 1/2] ref: Prevent instantiating unnecessary Date objects Use Date.now() instead of new Date().getTime(). Resources: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/getTime https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/now --- packages/utils/src/misc.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/utils/src/misc.ts b/packages/utils/src/misc.ts index 61e3b5fdc5e3..8d86acb3c91c 100644 --- a/packages/utils/src/misc.ts +++ b/packages/utils/src/misc.ts @@ -350,7 +350,7 @@ function _htmlElementAsString(el: unknown): string { * Returns a timestamp in seconds with milliseconds precision. */ export function timestampWithMs(): number { - return new Date().getTime() / 1000; + return Date.now() / 1000; } // https://semver.org/#is-there-a-suggested-regular-expression-regex-to-check-a-semver-string From 7cdd8089a5a39d868c825d49b07eede5a2eec981 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kamil=20Og=C3=B3rek?= Date: Thu, 27 Feb 2020 08:49:05 +0100 Subject: [PATCH 2/2] fixed tests --- packages/node/test/transports/http.test.ts | 4 +++- packages/node/test/transports/https.test.ts | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/node/test/transports/http.test.ts b/packages/node/test/transports/http.test.ts index 6e08f0a9f42c..c3b837f91f80 100644 --- a/packages/node/test/transports/http.test.ts +++ b/packages/node/test/transports/http.test.ts @@ -98,9 +98,11 @@ describe('HTTPTransport', () => { const now = Date.now(); const mock = jest .spyOn(Date, 'now') + // Initialize _disabledUntil attribute + .mockReturnValueOnce(now) // Check for first event .mockReturnValueOnce(now) - // Setting disableUntil + // Setting disabledUntil .mockReturnValueOnce(now) // Check for second event .mockReturnValueOnce(now + (retryAfterSeconds / 2) * 1000) diff --git a/packages/node/test/transports/https.test.ts b/packages/node/test/transports/https.test.ts index b31deb893776..501d35c64200 100644 --- a/packages/node/test/transports/https.test.ts +++ b/packages/node/test/transports/https.test.ts @@ -104,9 +104,11 @@ describe('HTTPSTransport', () => { const now = Date.now(); const mock = jest .spyOn(Date, 'now') + // Initialize _disabledUntil attribute + .mockReturnValueOnce(now) // Check for first event .mockReturnValueOnce(now) - // Setting disableUntil + // Setting disabledUntil .mockReturnValueOnce(now) // Check for second event .mockReturnValueOnce(now + (retryAfterSeconds / 2) * 1000)