Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on a page load in a trace containing a replay doesn't include the replay_id #2400

Closed
bruno-garcia opened this issue Sep 11, 2024 · 2 comments · Fixed by #2408
Closed
Assignees

Comments

@bruno-garcia
Copy link
Member

Issue Description

Currently, replay on backend error is limited, when the replay isn't yet sampled.

But when the replay is already recording when the request is done to the backend, we can send that replay_id in the baggage header. Allowing for any events captured by the backend SDK to include it in the DSC. This should allow

Reproduction Steps

Add replay to the FE with replaysSessionSampleRate set to 1.0.
Cause an error on the BE when serving the request.

Expected Behavior

Replay attached to the BE error

Actual Behavior

no replay on the BE error.

Ruby Version

3.3.4

SDK Version

5.18.2

Integration and Its Version

No response

Sentry Config

No response

@bruno-garcia
Copy link
Member Author

bruno-garcia commented Sep 11, 2024

For reference, Python is adding to contexts directly, not just forwarding the DSC on the envelope header it seems: perhaps the code changed since

@sl0thentr0py
Copy link
Member

@antonpirker fyi, this logic seems to have gone away from python during the scope refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants