-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensures are incorrectly reported to sentry as "Fatal" errors #189
Comments
Thanks for raising this. Based on getsentry/relay#1677 they should indeed be |
Hey @skauker-iw, I can confirm that this is still not working as intended. I'll be taking another stab at it in connection to getsentry/sentry#38550 (comment) |
As an update: The issue is still reporting the incorrect severity but it is now possible to filter by crashtype itself. |
Hey, is there any update on this issue? Does the problem lie in symbolicator, crashreporter or sentry itself? |
This is a bug or lack of proper support in Sentry itself. |
Thanks! I don't know if this happened in the last few hours, but I think this might actually be resolved? Looking at our sentry dashboards, our ensures now have a yellow dot next to then, whereas out crashes and checks are marked as unhandled errors! |
I can report that this has not resolved itself in its entirety even in the latest release of Unreal and the sentry plugin- |
Definitely. It's not forgotten, I do have it on my todo list. |
Took a bit to get that thing out and running. Sorry about that. I tested it locally and it "works on my machine (tm)". Please let me know if you're still running into any issues. |
I can confirm I'm seeing it working beautifully on my panel! Thank you tons! |
Environment
How do you use Sentry?
Sentry SaaS (sentry.io)
Which version of the SDK?
0.1.1
How did you install the package? (Git-URL, Assetstore)
Git-URL
Which version of Unreal?
Unreal 4.26.1
Is this happening in Unreal (editor) or on a player like Android, iOS, Windows?
All cases I have tested -- Win64 Editor and packaged Win64 Development configurations (Shipping untested)
Steps to Reproduce
debug ensure
, which triggers a non-fatal ensure failure. This should trigger the crash reporter to send it to sentry automatically to the configured crash endpoint.Expected Result
I would expect a failing ensure to be at most a yellow "warning" or "error" when shown in the UI.
Actual Result
In the Sentry web UI, ensures are incorrectly marked as "Fatal"
I absolutely could be missing something here, or if there was a way to modify the CrashReportClient to allow changing the error level. I'd love to be able to be able to sort out actual crashes vs. failing ensures that correspond to less-critical logic errors.
The text was updated successfully, but these errors were encountered: