Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensures are incorrectly reported to sentry as "Fatal" errors #189

Closed
skauker-iw opened this issue Jan 9, 2023 · 10 comments · Fixed by getsentry/sentry#50717
Closed

Ensures are incorrectly reported to sentry as "Fatal" errors #189

skauker-iw opened this issue Jan 9, 2023 · 10 comments · Fixed by getsentry/sentry#50717
Assignees
Labels
Bug Something isn't working

Comments

@skauker-iw
Copy link

skauker-iw commented Jan 9, 2023

Environment

How do you use Sentry?
Sentry SaaS (sentry.io)

Which version of the SDK?
0.1.1

How did you install the package? (Git-URL, Assetstore)
Git-URL

Which version of Unreal?
Unreal 4.26.1

Is this happening in Unreal (editor) or on a player like Android, iOS, Windows?
All cases I have tested -- Win64 Editor and packaged Win64 Development configurations (Shipping untested)

Steps to Reproduce

  1. Make sure your project is set up with the crash reporter to report to sentry via the unreal specific endpoint.
  2. Open the project (works both in editor or in a packaged game) without a debugger attached
  3. Open the debug console, debug ensure, which triggers a non-fatal ensure failure. This should trigger the crash reporter to send it to sentry automatically to the configured crash endpoint.

Expected Result

I would expect a failing ensure to be at most a yellow "warning" or "error" when shown in the UI.

Actual Result

In the Sentry web UI, ensures are incorrectly marked as "Fatal"
image

I absolutely could be missing something here, or if there was a way to modify the CrashReportClient to allow changing the error level. I'd love to be able to be able to sort out actual crashes vs. failing ensures that correspond to less-critical logic errors.

@skauker-iw skauker-iw added Bug Something isn't working Platform: Unreal labels Jan 9, 2023
@bitsandfoxes
Copy link
Contributor

bitsandfoxes commented Jan 11, 2023

Thanks for raising this. Based on getsentry/relay#1677 they should indeed be warnings and not fatal. I'll take another look.

@bitsandfoxes bitsandfoxes self-assigned this Jan 11, 2023
@bitsandfoxes
Copy link
Contributor

Hey @skauker-iw, I can confirm that this is still not working as intended. I'll be taking another stab at it in connection to getsentry/sentry#38550 (comment)

@bitsandfoxes
Copy link
Contributor

As an update: The issue is still reporting the incorrect severity but it is now possible to filter by crashtype itself. unreal.crash_type:Assert.

@donallfg
Copy link

Hey, is there any update on this issue? Does the problem lie in symbolicator, crashreporter or sentry itself?

@bitsandfoxes
Copy link
Contributor

This is a bug or lack of proper support in Sentry itself.

@donallfg
Copy link

Thanks! I don't know if this happened in the last few hours, but I think this might actually be resolved? Looking at our sentry dashboards, our ensures now have a yellow dot next to then, whereas out crashes and checks are marked as unhandled errors!

@Tobias-Nilsson-Sharkmob
Copy link

Tobias-Nilsson-Sharkmob commented May 31, 2023

I can report that this has not resolved itself in its entirety even in the latest release of Unreal and the sentry plugin-
Some ensures are correctly marked as "Warning" in Sentry, but most issues that are ensures are still incorrectly marked as fatal for us.
The message for the issues does clearly state that it comes from an ensure and the ureal.crash_type does say "Ensure" so we can work around it but it would be nice to have this looked at.

@bitsandfoxes
Copy link
Contributor

Definitely. It's not forgotten, I do have it on my todo list.

@bitsandfoxes
Copy link
Contributor

Took a bit to get that thing out and running. Sorry about that. I tested it locally and it "works on my machine (tm)". Please let me know if you're still running into any issues.

@skauker-iw
Copy link
Author

I can confirm I'm seeing it working beautifully on my panel! Thank you tons!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants