Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve engine version-specific code handling #676

Open
tustanivsky opened this issue Nov 2, 2024 · 0 comments
Open

Improve engine version-specific code handling #676

tustanivsky opened this issue Nov 2, 2024 · 0 comments

Comments

@tustanivsky
Copy link
Collaborator

Since Sentry plugin supports multiple Unreal Engine versions there is often a need to maintain its version-specific code. For instance, API that allows disabling Unreal's default crash-capturing mechanism appeared only in UE 5.2.

To handle version-specific code we're using #if-s combined with ENGINE_MAJOR_VERSION/ENGINE_MINOR_VERSION macro defined here. The existing checks like #if ENGINE_MAJOR_VERSION == 5 can be improved by making them more future-proof (i.e. for the situation when UE6 arrives) with something like ENGINE_MAJOR_VERSION != 4.

Another good example of how to check engine version can be found in EngineVersionComparison.h.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant