-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider all stack traces for grouping #60184
Comments
Assigning to @getsentry/support for routing ⏲️ |
Routing to @getsentry/product-owners-issues for triage ⏲️ |
@kerenkhatiwada, can you please share some links to events which show this behavior? And when you say "multiple stacktraces," do you mean events with error groups or chained errors, or something else? |
Here is an event where we were able to reproduce it. This occurs for javascript error.cause issues. However, AggregateErrors are grouped by all stack traces. |
Thanks for that. And yeah, this is just a slight twist on #59679 from earlier this week. As it happens, Question: The current fix for the linked issue is to consider the top error rather than the wrapped one. Would that serve your purposes, or would you actually want both stacks to be included? |
React 19 will start leveraging the Unfortunately, in Sentry, issues are grouped by the actual error message ("There was an error while hydrating but React was able to recover by") not by the cause. I think having the parent as an issue is still nice as an umbrella issue. But the cause should be in a separate issue as well. Ideally with the same trace parent. |
thank you @eps1lon -- will get with the team internally and figure out next steps here. |
React 19 concerns fixed with #72593 |
Problem Statement
At the moment it seems Sentry groups using only one stack trace. This is an issue when there are two stack traces for an issue that are completely different.
Solution Brainstorm
Consider all stack traces for grouping
Product Area
Issues
The text was updated successfully, but these errors were encountered: