Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Replay Details - Breadcrumbs] Introduce new category ui.lifecycle for mobile #69256

Open
Tracked by #64379
romtsn opened this issue Apr 18, 2024 · 1 comment
Open
Tracked by #64379

Comments

@romtsn
Copy link
Member

romtsn commented Apr 18, 2024

This is rather a discussion point.

If we're sending all lifecycle events with the navigation category, it looks something like this (which is not pretty):
image

There are multiple potential solutions to this:

  • Only have one breadcrumb per screen (i.e. no lifecycle events, just one navigation breadcrumb when a screen is interactable/visible, meaning Activity.onResume or ViewController.viewDidAppear)
  • OR introduce new category ui.lifecycle which will have lifecycle crumbs in addition to navigation crumbs. Perhaps we could make them collapsible under a parent navigation breadcrumb for a screen
  • OR keep it as-is, as shown on the screenshot above

I'm personally leaning towards the first option here, meaning there's no work on the frontend side and we can just backlog it, and re-iterate after customers' feedback. The SDKs will do the filtering, and only send one navigation breadcrumb per screen navigation event.

@michellewzhang
Copy link
Member

michellewzhang commented Apr 22, 2024

thoughts:

  • we could have only one nav breadcrumb per screen (good enough for GA)
  • potentially another lifecycle category based on user feedback, we like this idea: "Perhaps we could make them collapsible under a parent navigation breadcrumb for a screen"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants