Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(seer grouping): Add call to Seer to optimized grouping flow in ingest #75266

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

lobsterkatie
Copy link
Member

There are currently two paths ingest can follow when saving an event: the existing _save_aggregate (which runs unnecessary calculations when a project is in a grouping config transition) and the newer _save_aggregate_new (which only does extra calculations when necessary). Until now, Seer grouping had only been integrated into the first path, meaning we had to turn off the second path entirely. This adds the Seer logic to the new path, so we don't have to choose between the features.

Note: The tests look like they've changed more than they actually have. In reality, all that's happened is that the body of each test has been parameterized and wrapped in the following code, which forces it to run through both paths mentioned above:

for use_optimized_grouping, existing_event_message, new_event_message in [
    (True, "Dogs are great!", "Adopt don't shop"),
    (False, "Maisey is silly", "Charlie is goofy"),
]:
    with patch(
        "sentry.event_manager.project_uses_optimized_grouping",
        return_value=use_optimized_grouping,
    ):

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 30, 2024
@lobsterkatie lobsterkatie marked this pull request as ready for review July 30, 2024 17:40
@lobsterkatie lobsterkatie requested a review from a team as a code owner July 30, 2024 17:40
@lobsterkatie lobsterkatie force-pushed the kmclb-pre-seer-in-optimized-grouping-flow-clean-up branch from 4e59667 to 117e23a Compare July 30, 2024 18:40
@lobsterkatie lobsterkatie force-pushed the kmclb-add-seer-call-to-optimized-grouping-flow branch from d2d188d to d660610 Compare July 30, 2024 18:40
@lobsterkatie lobsterkatie force-pushed the kmclb-pre-seer-in-optimized-grouping-flow-clean-up branch from 117e23a to bd0a554 Compare August 1, 2024 17:38
@lobsterkatie lobsterkatie force-pushed the kmclb-add-seer-call-to-optimized-grouping-flow branch from d660610 to 2e55423 Compare August 1, 2024 17:39
Base automatically changed from kmclb-pre-seer-in-optimized-grouping-flow-clean-up to master August 1, 2024 18:33
@lobsterkatie lobsterkatie force-pushed the kmclb-add-seer-call-to-optimized-grouping-flow branch from 2e55423 to c0fb2c3 Compare August 1, 2024 18:37
@lobsterkatie lobsterkatie merged commit 71989f9 into master Aug 1, 2024
49 checks passed
@lobsterkatie lobsterkatie deleted the kmclb-add-seer-call-to-optimized-grouping-flow branch August 1, 2024 19:12
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants