Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(styles) deprecate space export and add space to theme #75790

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Aug 7, 2024

First step towards migrating space to theme obj. This change only deprecates the direct space export and not the one accessible on the theme

@JonasBa JonasBa requested a review from vuluongj20 August 7, 2024 23:32
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 7, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
static/app/styles/space.tsx 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #75790      +/-   ##
==========================================
- Coverage   79.96%   78.16%   -1.81%     
==========================================
  Files        7064     6894     -170     
  Lines      316313   306751    -9562     
  Branches    52794    52794              
==========================================
- Hits       252953   239763   -13190     
+ Misses      62922    60600    -2322     
- Partials      438     6388    +5950     

@JonasBa JonasBa added the Do Not Merge Don't merge label Aug 8, 2024
@JonasBa
Copy link
Member Author

JonasBa commented Aug 8, 2024

Holding off on merging until I can validate this does not noticeably impact performance.

@getsantry
Copy link
Contributor

getsantry bot commented Sep 15, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Sep 15, 2024
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to see this change land!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants