Wmak/ref/remove remaining params references

[wmak]

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

[codecov]

❌ 972 Tests Failed:

Tests completed	Failed	Passed	Skipped
21641	972	20669	202

View the top 3 failed tests by shortest run time

tests.sentry.search.events.test_fields�test_combinator_names_are_reserved[ArrayCombinator]

Stack Traces | 0.055s run time

#x1B[1m#x1B[.../search/events/test_fields.py#x1B[0m:286: in test_combinator_names_are_reserved
    fields = UnresolvedQuery(dataset=Dataset.Discover, params={})
#x1B[1m#x1B[31mE   TypeError: BaseQueryBuilder.__init__() got an unexpected keyword argument 'params'#x1B[0m

tests.sentry.search.events.test_fields�test_range_funtions[count_range(greater, 2020-05-03T06:48:57) as count_range_1-expected3]

Stack Traces | 0.057s run time

#x1B[1m#x1B[.../search/events/test_fields.py#x1B[0m:279: in test_range_funtions
    fields = resolve_snql_fieldlist([field])
#x1B[1m#x1B[.../search/events/test_fields.py#x1B[0m:215: in resolve_snql_fieldlist
    return UnresolvedQuery(Dataset.Discover, {}).resolve_select(fields, [])
#x1B[1m#x1B[.../events/builder/base.py#x1B[0m:139: in __init__
    self.filter_params = self.params.filter_params
#x1B[1m#x1B[31mE   AttributeError: 'dict' object has no attribute 'filter_params'#x1B[0m

tests.sentry.search.events.test_fields�test_range_funtions[percentile_range(transaction.duration, 0.5, greater, 2020-05-03T06:48:57) as percentile_range_1-expected0]

Stack Traces | 0.058s run time

#x1B[1m#x1B[.../search/events/test_fields.py#x1B[0m:279: in test_range_funtions
    fields = resolve_snql_fieldlist([field])
#x1B[1m#x1B[.../search/events/test_fields.py#x1B[0m:215: in resolve_snql_fieldlist
    return UnresolvedQuery(Dataset.Discover, {}).resolve_select(fields, [])
#x1B[1m#x1B[.../events/builder/base.py#x1B[0m:139: in __init__
    self.filter_params = self.params.filter_params
#x1B[1m#x1B[31mE   AttributeError: 'dict' object has no attribute 'filter_params'#x1B[0m

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

[getsantry]

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

[getsantry]

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀