feat(issue-details): Add streamlined sidebar and activity #77958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
roggenkemper
commented
Sep 23, 2024
| } from 'sentry/icons'; | ||
| import {GroupActivityType} from 'sentry/types/group'; | ||
|
|
||
| export const GroupActivityTypeIconMapping: Record<GroupActivityType, React.ReactNode> = { |
There was a problem hiding this comment.
This is my attempt at getting somewhat unique icons for each different activity type that somewhat matches the activity they are describing. will happily take suggestions for improvements here.
roggenkemper
commented
Sep 23, 2024
| @@ -0,0 +1,701 @@ | |||
| import {Fragment} from 'react'; | |||
There was a problem hiding this comment.
this is a copy of the existing file but with each message reworded to fit our new title/message format
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
…y into roggenkemper/sidebartest
…y into roggenkemper/sidebartest
scttcper
reviewed
Sep 23, 2024
| import {GroupActivityType} from 'sentry/types/group'; | ||
|
|
||
| export const GroupActivityTypeIconMapping: Record<GroupActivityType, React.ReactNode> = { | ||
| [GroupActivityType.NOTE]: <IconFile />, |
There was a problem hiding this comment.
i think you want to do just IconFile and render it later since this version makes it hard to pass any props to and renders them when the app loads. Here's one with icons i tried recently
sentry/static/app/components/events/errorLevelText.tsx
Lines 23 to 30 in e7cc9c4
Suggested change
| [GroupActivityType.NOTE]: <IconFile />, | |
| [GroupActivityType.NOTE]: IconFile, |
scttcper
approved these changes
Sep 23, 2024
scttcper
reviewed
Sep 23, 2024
| GroupActivityType, | ||
| IconWithDefaultProps | ||
| > = { | ||
| [GroupActivityType.NOTE]: {Component: IconFile, defaultProps: {}}, |
There was a problem hiding this comment.
if you don't need the defaultProps you don't need to add it lol
scttcper
reviewed
Sep 23, 2024
| [GroupActivityType.AUTO_SET_ONGOING]: {Component: IconPlay, defaultProps: {}}, | ||
| [GroupActivityType.SET_ESCALATING]: { | ||
| Component: IconGraph, | ||
| defaultProps: {type: 'area'}, |
|
PR reverted: e696dc7 |
getsentry-bot
added a commit
that referenced
this pull request
Sep 24, 2024
…7958)" This reverts commit 2446a87. Co-authored-by: scttcper <[email protected]>
|
Reverting because this change broke thirds layout on other pages |
roggenkemper
added a commit
that referenced
this pull request
Sep 24, 2024
new version of #77958 , which was reverted because the condition for not using a grid layout was being read as false (undefined) on non-issues pages. this pr updates it to only change the layout of the issue details container so it won't affect any other page.
0Calories
pushed a commit
that referenced
this pull request
Sep 25, 2024
this pr adds in the dismissible sidebar and a first version of adding activity to the sidebar. the sidebar can now be dismissed, allowing for the rest of the issue details page to be displayed larger. the first version of activity in the sidebar will only show activities, the ability to comment is not added yet (will be done in a separate PR). Because of this, the tab will still be there until then. 
0Calories
pushed a commit
that referenced
this pull request
Sep 25, 2024
…7958)" This reverts commit 2446a87. Co-authored-by: scttcper <[email protected]>
0Calories
pushed a commit
that referenced
this pull request
Sep 25, 2024
new version of #77958 , which was reverted because the condition for not using a grid layout was being read as false (undefined) on non-issues pages. this pr updates it to only change the layout of the issue details container so it won't affect any other page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr adds in the dismissible sidebar and a first version of adding activity to the sidebar. the sidebar can now be dismissed, allowing for the rest of the issue details page to be displayed larger. the first version of activity in the sidebar will only show activities, the ability to comment is not added yet (will be done in a separate PR). Because of this, the tab will still be there until then.