Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(issues): Use router to open drawers #78103

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

feat(issues): Use router to open drawers #78103

wants to merge 11 commits into from

Conversation

scttcper
Copy link
Member

@scttcper scttcper commented Sep 25, 2024 •
edited
Loading

the buttons no longer open the drawers, instead they're just links to the existing routes. A useEffect in group details opens the appropriate drawer.

To follow up on:

  • What should the routes that don't have drawers do? Merged issues was a tab before

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 25, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 25, 2024 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
7914 1 7913 0
View the top 1 failed tests by shortest run time 
EventAttachments can open the group attachments drawer EventAttachments can open the group attachments drawer
Stack Traces | 1.11s run time 
Error: Unable to find role="complementary" and name "attachments drawer"

Ignored nodes: comments, script, style
...
    at waitForWrapper (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:163:27)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:86:33
    at Object.<anonymous> (.../components/events/eventAttachments.spec.tsx:237:46)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@codecov Codecov
Copy link

codecov bot commented Sep 25, 2024 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 24.53kB (-0.08%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 30.75MB 24.53kB (-0.08%) ⬇️

@scttcper scttcper marked this pull request as ready for review September 27, 2024 23:06
@scttcper scttcper requested a review from a team as a code owner September 27, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@scttcper