Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(uptime): Remove uptime-display-wizard-create flag usage #78145

Merged
merged 1 commit into from
Sep 25, 2024
Merged

ref(uptime): Remove uptime-display-wizard-create flag usage #78145

merged 1 commit into from
Sep 25, 2024
+6 −7

Conversation

evanpurkhiser
Copy link
Member

No description provided.

@evanpurkhiser evanpurkhiser requested a review from a team as a code owner September 25, 2024 20:56
@evanpurkhiser evanpurkhiser requested review from a team and removed request for a team September 25, 2024 20:56
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 25, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 25, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
7881 1 7880 0
View the top 1 failed tests by shortest run time 
AlertWizard should render alerts for enabled features AlertWizard should render alerts for enabled features
Stack Traces | 0.053s run time 
Error: expect(received).toEqual(expected) // deep equality

Expected: 5
Received: 6
    at Object.<anonymous> (.../alerts/wizard/index.spec.tsx:73:32)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@evanpurkhiser evanpurkhiser enabled auto-merge (squash) September 25, 2024 21:48
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-uptime-remove-uptime-display-wizard-create-flag-usage branch from f6c24a7 to 701c577 Compare September 25, 2024 21:48
@evanpurkhiser evanpurkhiser merged commit d79e4e4 into master Sep 25, 2024
42 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/ref-uptime-remove-uptime-display-wizard-create-flag-usage branch September 25, 2024 22:06
michellewzhang pushed a commit that referenced this pull request Sep 25, 2024
@evanpurkhiser @michellewzhang
ref(uptime): Remove uptime-display-wizard-create flag usage (#78145)
5f4129c
@gaprl gaprl added the Trigger: Revert add to a merged PR to revert it (skips CI) label Sep 26, 2024
@getsentry-bot
Copy link
Contributor

PR reverted: 6d05f34

getsentry-bot added a commit that referenced this pull request Sep 26, 2024
@getsentry-bot @gaprl
Revert "ref(uptime): Remove uptime-display-wizard-create flag usage (#…
6d05f34 
…78145)"

This reverts commit d79e4e4.

Co-authored-by: gaprl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michellewzhang michellewzhang michellewzhang approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components Trigger: Revert add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@evanpurkhiser @getsentry-bot @michellewzhang @gaprl