Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(grouping): Combine functions gathering metrics into one #78262

Open
wants to merge 1 commit into
base: kmclb-remove-save_aggregate-and-friends
Choose a base branch
from

Conversation

lobsterkatie
Copy link
Member

When we had two versions of the grouping code (optimized and non-optimized), the differences in their logic meant that the helper recording metrics had to be split into two. (In the non-optimized path, we didn't have the information we needed for certain metrics early enough to record them in the main metrics-gathering function.) Now that we've switched to only using the optimized path (and have removed the old path), we can pull those straggler metics into the main metrics helper.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 27, 2024
@lobsterkatie lobsterkatie force-pushed the kmclb-remove-save_aggregate-and-friends branch from ca77244 to e21e939 Compare September 27, 2024 16:59
@lobsterkatie lobsterkatie force-pushed the kmclb-combine-grouping-metrics-helpers branch from ce3c800 to ebdccf2 Compare September 27, 2024 16:59
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                             Coverage Diff                             @@
##           kmclb-remove-save_aggregate-and-friends   #78262      +/-   ##
===========================================================================
+ Coverage                                    77.18%   78.12%   +0.94%     
===========================================================================
  Files                                         7067     7067              
  Lines                                       311787   311786       -1     
  Branches                                     50957    50957              
===========================================================================
+ Hits                                        240638   243570    +2932     
+ Misses                                       59237    56461    -2776     
+ Partials                                     11912    11755     -157     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants