ref(grouping): Combine functions gathering metrics into one #78262
+22
−39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we had two versions of the grouping code (optimized and non-optimized), the differences in their logic meant that the helper recording metrics had to be split into two. (In the non-optimized path, we didn't have the information we needed for certain metrics early enough to record them in the main metrics-gathering function.) Now that we've switched to only using the optimized path (and have removed the old path), we can pull those straggler metics into the main metrics helper.