Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(grouping): Remove orphan todo re: adding Seer to _save_aggregate_new #78263

Merged

Conversation

lobsterkatie
Copy link
Member

This removes a TODO which became obsolete as of #75266 (and therefore should have been removed then) but which was missed at the time.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 27, 2024
@lobsterkatie lobsterkatie force-pushed the kmclb-remove-orphan-seer-cross-save_aggregate_new-todo branch from f43a1d2 to f22fd93 Compare September 27, 2024 16:43
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #78263       +/-   ##
===========================================
+ Coverage   57.37%   78.11%   +20.73%     
===========================================
  Files        7055     7067       +12     
  Lines      311278   311799      +521     
  Branches    50894    50967       +73     
===========================================
+ Hits       178598   243547    +64949     
+ Misses     122532    56493    -66039     
- Partials    10148    11759     +1611     

@lobsterkatie lobsterkatie force-pushed the kmclb-remove-orphan-seer-cross-save_aggregate_new-todo branch from f22fd93 to 59fe5c1 Compare September 27, 2024 18:32
@lobsterkatie lobsterkatie marked this pull request as ready for review September 27, 2024 19:09
@lobsterkatie lobsterkatie requested a review from a team as a code owner September 27, 2024 19:09
@lobsterkatie lobsterkatie merged commit 2e902bb into master Sep 27, 2024
50 checks passed
@lobsterkatie lobsterkatie deleted the kmclb-remove-orphan-seer-cross-save_aggregate_new-todo branch September 27, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants