Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(issue-views): Load in default view by default if issue views enabled) #78278

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MichaelSun48
Copy link
Member

Fixes a bug where you'd see the default query flash in the search bar breifly when loading /issues/ , or when clicking the issues tab. Does this by hijacking the saved searches HOC, and returning the default issue view instead of the default search view if the organization has the feature enabled.

This might also help the views load in faster, since the fetch request occurs earlier in the rendering cycle.

I could not figure out how to stop the page filters from flashing some values, but I will continue to look into this:

Before:

Screen.Recording.2024-09-27.at.12.08.09.PM.mov

After

Screen.Recording.2024-09-27.at.12.09.32.PM.mov

notice how in the After video, the search query remains static even after clicking the issues tab

@MichaelSun48 MichaelSun48 requested a review from a team as a code owner September 27, 2024 19:10
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Bundle Report

Changes will increase total bundle size by 85 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 30.77MB 85 bytes (0.0%) ⬆️

Copy link

codecov bot commented Sep 27, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
7902 1 7901 0
View the top 1 failed tests by shortest run time
SlowestFunctionsWidget renders example transactions SlowestFunctionsWidget renders example transactions
Stack Traces | 1.33s run time
Error: Unable to find an element by: [data-test-id="transactions-list"]

Ignored nodes: comments, script, style
...
    at waitForWrapper (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:163:27)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:86:33
    at Object.<anonymous> (.../profiling/landing/slowestFunctionsWidget.spec.tsx:159:46)
    at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:316:40)
    at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant