Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(alerts): Beef up dynamic rule update test #78284

Merged
merged 1 commit into from
Sep 27, 2024
Merged

ref(alerts): Beef up dynamic rule update test #78284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions tests/sentry/incidents/test_logic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1658,33 +1658,45 @@ def test_update_dynamic_alerts(self, mock_seer_request):
time_window=60,
detection_type=AlertRuleDetectionType.DYNAMIC,
)
snuba_query = SnubaQuery.objects.get(id=dynamic_rule.snuba_query_id)
assert dynamic_rule.snuba_query.resolution == 60 * 60
assert mock_seer_request.call_count == 1
mock_seer_request.reset_mock()
# update time_window
update_alert_rule(dynamic_rule, time_window=30)
update_alert_rule(
dynamic_rule,
time_window=30,
detection_type=AlertRuleDetectionType.DYNAMIC,
)
snuba_query.refresh_from_db()
assert snuba_query.resolution == 30 * 60
assert mock_seer_request.call_count == 0
mock_seer_request.reset_mock()
# update name
update_alert_rule(dynamic_rule, name="everything is broken")
dynamic_rule.refresh_from_db()
assert dynamic_rule.name == "everything is broken"
assert mock_seer_request.call_count == 0
mock_seer_request.reset_mock()
# update query
update_alert_rule(
dynamic_rule,
query="is:unresolved",
time_window=30,
detection_type=AlertRuleDetectionType.DYNAMIC,
)
assert mock_seer_request.call_count == 1
snuba_query.refresh_from_db()
assert snuba_query.query == "is:unresolved"
mock_seer_request.reset_mock()
# update aggregate
update_alert_rule(
dynamic_rule,
aggregate="count_unique(user)",
time_window=30,
detection_type=AlertRuleDetectionType.DYNAMIC,
)
assert mock_seer_request.call_count == 1
snuba_query.refresh_from_db()
assert snuba_query.aggregate == "count_unique(user)"

@with_feature("organizations:anomaly-detection-alerts")
@patch(
Expand Down
Loading