-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom measurements API #51
Comments
We need to update the list of SDKs and versions that support this in the docs here: |
good catch, I was not aware of this list, would you mind adding the missing SDKs? RN, Cocoa, Dart, and Android together with .NET? |
Yes. I'll start a draft PR for that and merge after the .NET SDK releases later today/tomorrow. |
Docs PR: getsentry/sentry-docs#5689 I didn't add React Native though, because its docs page for custom metrics is showing the default page for Javascript. Is that accurate? Or does it need its own? And if so, what version, etc? @krystofwoldrich |
The RN SDK inherits the docs from JS most of the time because they are the same, but this one should have its own because it has the JS SDK version instead of the RN version. |
I added RN 4.0.0 to the list in my PR, but there should be a separate docs PR to fix up that page. I'm not sure if you need other stuff for RN or just the version number. |
Users should be able to:
void Transaction#setMeasurement(String name, num value, {SentryMeasurementUnit? unit})
transaction.setMeasurement('name', 10, unit: SentryMeasurementUnit.milliseconds);
When the transaction is finished, setting a custom measurement is a no-op; see getsentry/sentry-dart#1026.
Depends on
#31
Spec https://develop.sentry.dev/sdk/event-payloads/transaction/
DACI https://www.notion.so/sentry/Custom-Measurements-Units-Protocol-7d3752b43bb946bf87d96e401268ca02
Patch the docs and add code snippets https://github.com/getsentry/sentry-docs/edit/master/src/platforms/common/performance/instrumentation/performance-metrics.mdx
The text was updated successfully, but these errors were encountered: