Project: Add Sampling Decision to Trace Envelope Header

[cleptric]

Project Board

https://github.com/orgs/getsentry/projects/129

Web Frontend SDKs

Beta Give feedback

1. Add Sampling Decision to Trace Envelope Header sentry-javascript#8482
   Feature: Spans Status: Backlog +2
   

Web Backend SDKs

Beta Give feedback

1. Add the sampling decision to the trace envelope header sentry-php#1562
   Status: In Progress Type: Improvement +2
   
2. Add Sampling Decision to Trace Envelope Header sentry-python#2237
   Enhancement +1
   
3. Add Sampling Decision to Trace Envelope Header sentry-ruby#2064
   enhancement +1
   
4. Add Sampling Decision to Trace Envelope Header sentry-go#665
   Status: In Progress Type: Improvement +2
   
5. Add Sampling Decision to Trace Envelope Header sentry-java#2832
   Platform: Java +1
   
6. Add Sampling Decision to Trace Envelope Header sentry-dotnet#2470
   Effort: Small Impact: Medium +2
   

Mobile SDKs

Beta Give feedback

1. Add Sampling Decision to Trace Envelope Header sentry-dart#1579
   Platform: Dart enhancement +2
   
2. Add Sampling Decision to Trace Envelope Header sentry-cocoa#3201
   Platform: Cocoa Type: Enhancement +2

Description

from @iambriccardo

Right now the error tagging doesn't support client side sampling, that is, if a trace is sampled out by the head of the trace, this information is not propagated in the trace header (aka dsc). This means that from the perspective of dynamic sampling, we don't know whether the trace has been sampled out on the client and this could lead to false positives.

We would need to fix this by having the client SDKs add the client sampling decision in the dsc that will be attached to the error. This client sampling decision will work similarly to dynamic sampling, that is, if the head is sampled out all the children are sampled out and vice versa.

Client Sampling Decision DSC RFC

[AbhiPrasad]

To save on bundle size I would like to only add logic that sets sampled on the DSC if there is an active transaction.

@iambriccardo does that seem fine?

[cleptric]

@AbhiPrasad Yep, the same behaviour in PHP, due to other reasons, though 😬

[stephanie-anderson]

Closing, project is completed