Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.rst is not correctly rendered #1411

Closed
edigaryev opened this issue Jan 12, 2024 · 16 comments
Closed

README.rst is not correctly rendered #1411

edigaryev opened this issue Jan 12, 2024 · 16 comments

Comments

@edigaryev
Copy link

Screenshot:

Screenshot 2024-01-13 at 01 20 25
@tidux
Copy link

tidux commented Jan 12, 2024

I think imgur is part of the problem. "Direct file links" aren't anymore if it detects certain user agents, including all mobile browsers. Just put the gif in the repo.

@felixfontein
Copy link
Contributor

Interesting, this must have changed recently. A few days ago I was still able to see the rendered version.

@chrisgilmerproj
Copy link

I have opened a github ticket about this because I wasn't sure what was going on and I couldn't even get to the issues tab for this repo. I think they might try to optimize to fix this issue. However, reducing the size of the file would be a big help. For different sections you could put them in a docs/ directory with links from the original file.

Here's the error as I'm seeing it now:

Screen Shot 2024-01-12 at 2 07 35 PM

@hiddeco
Copy link
Member

hiddeco commented Jan 13, 2024

This is indirectly related to getsops/community#9

@felixfontein
Copy link
Contributor

@chrisgilmerproj do you have a link to that issue? This is quite a problem for many other projects as well (quite a few changelogs for Ansible-related projects use RST and also no longer render on GitHub).

@felixfontein
Copy link
Contributor

I found https://github.com/orgs/community/discussions/86715 so far, but that only shows others are having this problem too.

@chrisgilmerproj
Copy link

@felixfontein - Here's what I got from Github support before they closed my ticket:

Thank you for writing in! I'm sorry you have experienced this problem.

I’ve escalated your report to our engineering team for further investigation.

I'm afraid our system may mark this ticket as "solved" now that the issue has been created with the engineering team, but that doesn't mean we've forgotten about it.

We'll be back in touch when we have any updates!

If there is anything else I can help you with, please let me know 😁

I have left a request for them to link me to the engineering ticket so that I might connect you to it.

Thanks again for looking into this.

@felixfontein
Copy link
Contributor

@chrisgilmerproj thanks a lot! My guess is that they changed a timeout, or maybe they pre-rendered these documents in the past and stopped doing that... There has been no change to the renderer itself in the last months (or at least none to https://github.com/github/markup, which apparently contains the code).

@felixfontein
Copy link
Contributor

As a temporary fix, we could programmatically convert the RST file to MD until all PRs modifying the RST have been merged and we decided how to continue with the README in general. I've created #1424 for this.

@getsops/maintainers what do you think?

@Gowiem
Copy link

Gowiem commented Feb 2, 2024

@hiddeco are you the main maintainer nowadays? Anyway we can get the workaround PR merged to fix this issue? I am giving a talk on SOPS next week and this issue concerns me as folks are going to come to the project and think it's dead / not run currently, which makes my talk look bad haha. Please help out if you can!

@hiddeco
Copy link
Member

hiddeco commented Feb 3, 2024

The project is far from dead or unmaintained, and we have multiple people looking after it including plans in the works to ramp up the engagement with the community.

Due to some unfortunate events around the company that used to pay me for my work in open-source, in combination with COVID and some other family related matters, I have been distracted for the last month(s). But I have the following two weeks available to spend on going through the backlog.

@felixfontein
Copy link
Contributor

The README is now rendering again - see https://github.com/orgs/community/discussions/86715#discussioncomment-8893219. Unfortunately the code blocks have no syntax highlighting, but instead have underlines. But hey, at least it's readable again... 🤷

@felixfontein felixfontein changed the title README.rst is not being rendered due to its size README.rst is not correctly rendered Mar 24, 2024
@felixfontein
Copy link
Contributor

The broken RST code block syntax highlighting has a separate discussion on GitHub: https://github.com/orgs/community/discussions/113792

@felixfontein
Copy link
Contributor

The syntax highlighting has been fixed. What's still missing is the Table of Contents.

@felixfontein
Copy link
Contributor

The table of contents is back as well. I think this is now (finally) resolved.

We're planning to move all documentation to a proper docsite anyway, so I'm going to close this. Thanks everyone!

@chrisgilmerproj
Copy link

Thanks for handling this! We appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants