Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels, debug markers, and validation layers should be available on release builds #2316

Closed
aloucks opened this issue Dec 25, 2021 · 0 comments · Fixed by #4230
Closed

Labels, debug markers, and validation layers should be available on release builds #2316

aloucks opened this issue Dec 25, 2021 · 0 comments · Fixed by #4230
Labels
area: api Issues related to API surface help required We need community help to make this happen. type: enhancement New feature or request

Comments

@aloucks
Copy link
Contributor

aloucks commented Dec 25, 2021

Is your feature request related to a problem? Please describe.
I was trying to debug something in Renderdoc and none of the labels or debug groups were showing up. I switched to a debug build and my labels and groups started showing up. The issue is that debug builds can be painfully slow in some cases. I often just use release builds.

Describe the solution you'd like
I'd like to be able to set two flags during instance creation. One to enable debug markers, groups, and labels and a separate flag to enable validation. It looks like these already exist as flags on the hal Instance:

if cfg!(debug_assertions) {
flags |= hal::InstanceFlags::VALIDATION;
flags |= hal::InstanceFlags::DEBUG;
}

Describe alternatives you've considered

  1. I could enable debug_assertions in release builds or change debug builds to be more optimized. I'd still prefer a runtime flag during instance creation.
  2. I could use the hal API to create the instance.

Additional context
The labels and debug groups have a cost associated with the string allocation but I think there's opportunity for improvement here by using string interning or other options to minimize the allocation.

@kvark kvark added area: api Issues related to API surface help required We need community help to make this happen. type: enhancement New feature or request labels Dec 25, 2021
@teoxoy teoxoy mentioned this issue Oct 11, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: api Issues related to API surface help required We need community help to make this happen. type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants