Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wgpu-hal.gles] Error log for failed GLES heuristics #5266

Merged

Conversation

PolyMeilex
Copy link
Contributor

GLES backend guesses the texture type, and it often guesses wrong, let's save people some debugging time by informing them about this madness until there is a proper solution.

Info about those limitations in #1614 and #1574
Related iced bug that took way too long to debug iced-rs/iced#2259

@PolyMeilex PolyMeilex requested a review from a team as a code owner February 18, 2024 20:35
@PolyMeilex PolyMeilex force-pushed the error-log-for-gles-failed-heuristics branch from 9010732 to 8a56cea Compare February 18, 2024 20:37
@PolyMeilex PolyMeilex force-pushed the error-log-for-gles-failed-heuristics branch from 8a56cea to 6a3d81c Compare February 18, 2024 20:45
nical
nical previously requested changes Feb 19, 2024
Copy link
Contributor

@nical nical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks useful, thanks! Just a couple of tweaks and this is good to go.

wgpu-hal/src/gles/mod.rs Outdated Show resolved Hide resolved
wgpu-hal/src/gles/mod.rs Outdated Show resolved Hide resolved
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

CHANGELOG.md Outdated Show resolved Hide resolved
@cwfitzgerald cwfitzgerald enabled auto-merge (squash) February 19, 2024 20:14
@cwfitzgerald cwfitzgerald merged commit 2e9ee0a into gfx-rs:trunk Feb 19, 2024
27 checks passed
@PolyMeilex PolyMeilex deleted the error-log-for-gles-failed-heuristics branch February 19, 2024 20:34
@cwfitzgerald cwfitzgerald added the PR: needs back-porting PR with a fix that needs to land on crates label Feb 29, 2024
cwfitzgerald added a commit to cwfitzgerald/wgpu that referenced this pull request Feb 29, 2024
cwfitzgerald added a commit to cwfitzgerald/wgpu that referenced this pull request Feb 29, 2024
@cwfitzgerald cwfitzgerald removed the PR: needs back-porting PR with a fix that needs to land on crates label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants